Replace Connection.RemoteAddr() by Connection()

[tigrannajaryan]

I am implementing TLS in the example server and found that I need access to the underlying net.Conn. I added Connection() method to access it. Now that we have access to net.Conn, RemoteAddr() is no longer needed, it can be substituted by Connection().RemoteAddr().

Note: this is a breaking change.

[codecov]

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.77 ⚠️

Comparison is base (efddaa2) 76.11% compared to head (50dae77) 75.34%.

❗ Current head 50dae77 differs from pull request most recent head c9d16ee. Consider uploading reports for the commit c9d16ee to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   76.11%   75.34%   -0.77%     
==========================================
  Files          24       24              
  Lines        1834     1866      +32     
==========================================
+ Hits         1396     1406      +10     
- Misses        326      342      +16     
- Partials      112      118       +6     

Impacted Files	Coverage Δ
client/types/callbacks.go	66.66% <ø> (ø)
server/httpconnection.go	33.33% <0.00%> (ø)
client/internal/mockserver.go	82.35% <85.71%> (+0.31%)	⬆️
server/serverimpl.go	58.92% <94.73%> (+0.37%)	⬆️
client/httpclient.go	95.00% <100.00%> (+0.26%)	⬆️
client/internal/httpsender.go	72.22% <100.00%> (+1.25%)	⬆️
server/callbacks.go	68.18% <100.00%> (-4.55%)	⬇️
server/wsconnection.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[andykellr]

I think the change is good. I would prefer we use the name "Connection" or "NetworkConnection" (seems redundant), rather than match the package/struct name of the connection. I will let you decide.

[tigrannajaryan]

I think the change is good. I would prefer we use the name "Connection" or "NetworkConnection" (seems redundant), rather than match the package/struct name of the connection. I will let you decide.

Just to be clear, you suggest Connection() as the method name instead of NetConn()?

[andykellr]

I think the change is good. I would prefer we use the name "Connection" or "NetworkConnection" (seems redundant), rather than match the package/struct name of the connection. I will let you decide.

Just to be clear, you suggest Connection() as the method name instead of NetConn()?

Yes

[tigrannajaryan]

I think the change is good. I would prefer we use the name "Connection" or "NetworkConnection" (seems redundant), rather than match the package/struct name of the connection. I will let you decide.

Just to be clear, you suggest Connection() as the method name instead of NetConn()?

Yes

Done.