Sampling relevant: MUST -> SHOULD

open-telemetry · Sep 24, 2021 · d34c429 · d34c429
1 parent 8c840f8
commit d34c429
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py b/semantic-conventions/src/opentelemetry/semconv/templating/markdown/__init__.py
@@ -203,12 +203,13 @@ def to_creation_time_attributes(
         sampling_relevant_attrs: typing.List[SemanticAttribute],
         output: io.StringIO,
     ):
-        """Renders list of attributes that MUST be provided at creation time
+        """Renders list of attributes that SHOULD be provided at creation time
         :return:
         """
         if sampling_relevant_attrs:
             output.write(
-                "\nFollowing attributes MUST be provided **at span creation time** (when provided at all):\n\n"
+              "\nFollowing attributes SHOULD be provided **at span creation time** (when provided at all), " + 
+              "so they can be considered for sampling decisions:\n\n"""
             )
 
             for attr in sampling_relevant_attrs:

diff --git a/semantic-conventions/src/tests/data/markdown/sampling_relevant/expected.md b/semantic-conventions/src/tests/data/markdown/sampling_relevant/expected.md
@@ -14,7 +14,7 @@
 | [`net.peer.name`](span-general.md) | string | . | `.` | No |
 | [`net.peer.port`](span-general.md) | int | . |  | No |
 
-Following attributes MUST be provided **at span creation time** (when provided at all):
+Following attributes SHOULD be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions:
 
 * `http.method`
 * `http.url`