Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mejoras API #31

Merged
merged 15 commits into from
Jul 18, 2022
Merged

Mejoras API #31

merged 15 commits into from
Jul 18, 2022

Conversation

nico-mac
Copy link
Member

Acercándonos a una API v1.

Diría que también nos permite cerrar #12.

@nico-mac nico-mac requested a review from FarDust July 15, 2022 03:06
@@ -23,6 +23,7 @@ lxml = "^4.6.3"
aiohttp = {extras = ["speedups"], version = "^3.8.1"}
aiohttp-client-cache = {extras = ["sqlite"], version = "^0.5.2"}
sympy = "^1.10.1"
SQLAlchemy = ">=1.4.17,<=1.4.35"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@@ -9,12 +9,12 @@
ParseStrategy = Dict[str, Optional[Callable[[bs4.element.Tag], Any]]]


def clean_text(tag: bs4.element.Tag) -> str:
def clean_text(tag: "bs4.element.Tag") -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 😄

@nico-mac nico-mac merged commit 8896f87 into main Jul 18, 2022
@nico-mac nico-mac deleted the api-enhancements branch July 18, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants