Allow use of UNC paths on Windows #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #619.
kyllingstad
force-pushed
the
bugfix/619-unc-path-uris
branch
from
ba97425 to
fc067cd
Compare
eidekrist
approved these changes
Feb 28, 2024
|
The original issue (#619) is difficult to recreate in unittests too, but I did test locally on my machine that this PR solves it. (That is, I was able to run a simulation with an UNC path to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #619.
File URIs generally have the form
file://hostname/path/to/file. Whenhostnameis notlocalhost(nor empty) the file URI scheme leaves the file access mechanism unspecified. However, on Windows, such URIs are commonly interpreted as UNC paths, so in this case it would be\\hostname\path\to\file. This PR simply enables us to take advantage of this interpretation, which is built into the Windows API functions we already use.