-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/std filesystem #637
Conversation
The PR fails on file locking on windows.. Don't know how to fix.. |
I hope this PR is welcome. No need to use boost when we got the std available. The only caveat is that we need the fallback header in order to support gcc 6 and 7. We also need to fix the file locking unit test. @kyllingstad need your expertise on that. |
It's very welcome, in my opinion. I'll look into the file locking issue. |
Hopefully, this does the trick. The file locking mechanism has an internal cache of mutexes associated with different files, and each time one tries to create a new one, it checks whether a mutex exists for the file already. Since different paths (relative vs. absolute, links, etc.) can refer to the same file, it uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR replaces usage of boost::filesystem with std::filesystem.
In order to support gcc7, the header
fs_portability
is used, which falls back to std::experimental::filesystem.Thus, usage of
std::filesystem
should be done using the typealiascosim::filesystem