-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added health check for connections from SSP #374
Conversation
I tested with invalid |
As in nothing happened, or exception is thrown both for old and new solution? A test case could be the first connection for <ssd:Connection startElement="OuterWall1" startConnector="h_wall" endElement="Room1" endConnector="h_OuterWall"/> When specifying wrong/nonexistent |
https://gist.github.com/markaren/bb97bd40e2bce6ca2be9775001f0205c Thats the output from the debug build. As before the simulations just silently fails and hangs at the end. No exceptions. No error message. |
I removed use of |
Ok, I guess it has to do with the FMUs used by the gunnerus-case. They do not shutdown properly, so the application hangs and the user never gets the error message.. Because I get the correct error handling when loading the demo case in the data folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in mob session.
This fixes #336 with better handling of invalid connections specified in
SystemStructure.ssd
.The direct map lookup (i.e.
val = map[key]
) used in the previous solution could give some funky results, and might even create a valid but unintended connection.I added a try-catch around the call to
execution::add_connection()
creating a more detailed and hopefully understandable error message. I'm not sure if this is how we want to do things, so input is welcome.