Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Search component suggestion div is without ScrollArea #1378

Closed
babblebey opened this issue Jul 17, 2023 · 1 comment
Closed

bug: Search component suggestion div is without ScrollArea #1378

babblebey opened this issue Jul 17, 2023 · 1 comment

Comments

@babblebey
Copy link
Contributor

This thus seem like it was intentional and I want to assume it was indeed made that way in the absence of a ScrollArea component in the beta design system at initial implementation.

Here's what happens without (if (suggestions.length > 5) suggestions.length = 5;) limiting suggestions count to 5

screencast-localhost_3000-2023 07 17-07_30_36

I added a ScrollArea component to the design system recently #1283

Would any of you guys want to give implementing it into the Search component a shot?

Originally posted by @babblebey in #1374 (comment)
@babblebey babblebey mentioned this issue Jul 17, 2023
Closed
2 tasks
@aryanas159 aryanas159 mentioned this issue Jul 17, 2023
Closed
19 tasks
aryanas159 added a commit to aryanas159/app that referenced this issue Jul 17, 2023
@aryanas159
fix: issue open-sauced#1378 Search component suggestion div is withou…
34d08fd 
…t ScrollArea

Signed-off-by: Aryan Singh <114330931+aryanas159@users.noreply.github.com>
@babblebey
Copy link
Contributor Author

fixed in #1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Search component suggestion div is without ScrollArea aryanas159/app
1 participant
@babblebey