Fix npm install error by removing monaco-vim and updating dependencies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve npm install error by removing `monaco-vim` dependency and ensuring consistent versions of `react-scripts` and `@rescripts/utilities`. * **Remove `monaco-vim` dependency:** - Delete `monaco-vim` from `packages/inspector/package.json` and `packages/playground/package.json`. - Delete `packages/inspector/src/hooks/useMonacoVimMode.ts` and `packages/playground/src/hooks/useMonacoVimMode.tsx`. - Delete `packages/playground/__mocks__/monaco-vim.js`. * **Update files to remove `useMonacoVimMode` hook:** - Remove import and usage of `useMonacoVimMode` in `packages/inspector/src/containers/JSONRPCRequestEditor.tsx`. - Remove import and usage of `useMonacoVimMode` in `packages/inspector/src/containers/OptionsEditor.tsx`. - Remove import and usage of `useMonacoVimMode` in `packages/playground/src/App.tsx`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/open-rpc/tools?shareId=XXXX-XXXX-XXXX-XXXX).
* **Dependencies** - Update `@rescripts/cli` to the latest version in `packages/inspector/package.json`, `packages/playground/package.json`, and `packages/logs-react/package.json` - Update `@rescripts/utilities` to version `0.0.7` in `packages/inspector/package.json`, `packages/playground/package.json`, and `packages/logs-react/package.json` - Update `react-scripts` to version `3.4.4` in `packages/inspector/package.json`, `packages/playground/package.json`, `packages/logs-react/package.json`, and `packages/docs-react/package.json` - Update the `engines` field to `>=18.20.5` in `package.json` * **Node.js Version** - Add `.nvmrc` files specifying Node.js version `18.20.5` in the root directory and in each package directory - Update `.node-version` and `.nodenv` to `18.20.5` * **Documentation** - Add instructions for using `nvm` to manage Node.js versions in `README.md`
* **Remove `useMonacoVimMode` hook:** - Delete `packages/inspector/src/hooks/useMonacoVimMode.ts` - Delete `packages/playground/src/hooks/useMonacoVimMode.tsx` - Remove import and usage of `useMonacoVimMode` in `JSONRPCRequestEditor.tsx`, `OptionsEditor.tsx`, and `App.tsx` - Delete `packages/playground/__mocks__/monaco-vim.js` * **Update dependencies:** - Remove `monaco-vim` dependency from `inspector/package.json` and `playground/package.json` - Update `react-scripts`, `@rescripts/utilities`, and `@rescripts/cli` versions in `inspector/package.json`, `playground/package.json`, `logs-react/package.json`, and `docs-react/package.json` - Fix errors in `logs-react/package.json`
shanejonas
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve npm install error by removing
monaco-vimdependency and ensuring consistent versions ofreact-scriptsand@rescripts/utilities.Remove
monaco-vimdependency:monaco-vimfrompackages/inspector/package.jsonandpackages/playground/package.json.packages/inspector/src/hooks/useMonacoVimMode.tsandpackages/playground/src/hooks/useMonacoVimMode.tsx.packages/playground/__mocks__/monaco-vim.js.Update files to remove
useMonacoVimModehook:useMonacoVimModeinpackages/inspector/src/containers/JSONRPCRequestEditor.tsx.useMonacoVimModeinpackages/inspector/src/containers/OptionsEditor.tsx.useMonacoVimModeinpackages/playground/src/App.tsx.For more details, open the Copilot Workspace session.