Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p384_mlkem1024 hybrid added #361

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

bencemali
Copy link
Contributor

We would like to use a NIST P curve + ML-KEM hybrid and compliance reasons would mandate using P-384 and ML-KEM-1024.
We found that P-384 is the most accepted P-curve. See CNSA 1.0.
From the ML-KEM variants, level 5 will be the most widely accepted. See CNSA 2.0.
Having a P-384 + ML-KEM-1024 hybrid could be useful.

@bencemali bencemali requested a review from baentsch as a code owner February 29, 2024 17:00
@bencemali
Copy link
Contributor Author

We would also like a stable oid for this hybrid and we suggest our internal, under Tresorit. The oid is 1.3.6.1.4.1.42235.6.
See Tresorit OID.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @bencemali ! It seems you essentially added an entry to "generate.yml" and correctly built and formatted the code -- so from that perspective the PR is OK. In light of #351 I'm somewhat hesitant to merge this as-is, though: Could you point to a (draft) spec for this combination and would you be willing to take on OID management of this hybrid, e.g., change as and when it becomes standardized? If so, please add a corresponding (comment) entry at the top of "generate.yml" listing a contact (email address) and (draft) spec reference (or deployment case) for this new hybrid.

@bencemali
Copy link
Contributor Author

Hi @baentsch, as far as we know there is no draft for this combination. The reason I included our oid in the pull request is to provide a fixed oid, just to make sure it doesn't constantly change in oqs-provider. We intended for this oid to be permanent, until (and if) it is standardized. Of course any other oid would suffice.

@baentsch
Copy link
Member

baentsch commented Mar 1, 2024

We intended for this oid to be permanent, until (and if) it is standardized. Of course any other oid would suffice.

OK -- understood & makes sense. Please feel free to amend the PR by comment to state this (at the top of "generate.yml" or next to the OID). Otherwise, git blame will allow us to trace this in the future. A re-base to "main" would be nice to get CI to turn green, though.

@bencemali
Copy link
Contributor Author

Thanks, @baentsch!

@baentsch baentsch merged commit c442a5c into open-quantum-safe:main Mar 1, 2024
26 checks passed
@baentsch
Copy link
Member

baentsch commented Mar 1, 2024

Thanks for the contribution. Merged.

feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
* p384_mlkem1024 hybrid added

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
* p384_mlkem1024 hybrid added

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants