Protecting from NULL parameters #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwizz
reviewed
Feb 9, 2024
ghost
reviewed
Feb 9, 2024
ghost
approved these changes
Feb 12, 2024
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 13, 2024
* guard against possible NULL parameters passed * fix SECURITY status [skip ci] Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
* guard against possible NULL parameters passed * fix SECURITY status [skip ci] Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* guard against possible NULL parameters passed * fix SECURITY status [skip ci] Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* guard against possible NULL parameters passed * fix SECURITY status [skip ci] Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* guard against possible NULL parameters passed * fix SECURITY status [skip ci] Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more protections against incorrect use of the OpenSSL<->provider API, notably incorrect NULL pointers passed.
Thanks again to @pcwizz for pointing these out. Please check that the issues found are indeed resolved with this PR.
This PR also updates missing release information in SECURITY.md.