Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite sigs for mldsa trigger test failures #381

Closed
baentsch opened this issue Mar 26, 2024 · 3 comments · Fixed by #386
Closed

Composite sigs for mldsa trigger test failures #381

baentsch opened this issue Mar 26, 2024 · 3 comments · Fixed by #386
Labels
bug Something isn't working

Comments

@baentsch
Copy link
Member

Describe the bug
All mldsa* composite algs fail test_tls_full.py

To Reproduce
Steps to reproduce the behavior:
Run ./scripts/release-test.sh

Expected behavior
All tests pass

Screenshots

ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x25519_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x448_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p256_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p521_mlkem1024]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p384_mlkem1024]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p256_bikel1]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x25519_bikel1]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p384_bikel3]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x448_bikel3]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p521_bikel5]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p256_hqc128]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x25519_hqc128]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p384_hqc192]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-x448_hqc192]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_bp384-p521_hqc256]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_frodo1344aes]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_frodo1344shake]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_kyber512]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_kyber512]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p384_kyber768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x448_kyber768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_kyber768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_kyber768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_kyber1024]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_mlkem512]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_mlkem512]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p384_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x448_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_mlkem768]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_mlkem1024]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p384_mlkem1024]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_bikel1]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_bikel1]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p384_bikel3]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x448_bikel3]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_bikel5]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p256_hqc128]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x25519_hqc128]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p384_hqc192]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-x448_hqc192]
ERROR scripts/test_tls_full.py::test_sig_kem_pair[mldsa87_ed448-p521_hqc256]
================= 1458 passed, 351 errors in 337.82s (0:05:37) =================

Environment (please complete the following information):

  • OS: Ubuntu 22
  • OpenSSL version master
  • oqsprovider version main

This may only be a test setup error (as per log; will investigate myself) but this stalls the release of oqsprovider, so another pair or eyes would be welcome, @feventura
@baentsch baentsch added the bug Something isn't working label Mar 26, 2024
@feventura
Copy link
Contributor

I'll also look into it

@bhess
Copy link
Member

bhess commented Mar 26, 2024 •
edited
Loading

I'm preparing an update for the test.openquantumsafe.org server and am facing a similar issue - segfaults when loading a configuration using an mldsa*-composite.

  • OS: Ubuntu 20.04 LTS
  • OpenSSL version master
  • oqsprovider version main
  • liboqs version 0.10.0

@bhess
Copy link
Member

bhess commented Apr 4, 2024

I think the issue is that the sigalg entries and the code points are missing in oqsprov_capabilities.c for the composite signatures. I can do a PR with a proposed fix.

@bhess bhess mentioned this issue Apr 4, 2024
Merged
baentsch pushed a commit that referenced this issue Apr 7, 2024
@bhess
Add composite signatures to sigalg list & add code points. (#386)
50b8ed5 
Adds templates to generate oqs_sigalg_list entries and code points for composite signatures.

Fixes #381.

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add composite signatures to sigalg list & add code points. open-quantum-safe/oqs-provider
3 participants
@bhess @feventura @baentsch