Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive Updates and Optimizations to Docker Files #338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hawazyn
Copy link
Contributor

@Hawazyn Hawazyn commented Dec 24, 2024

Please check the commit message for detailed changes.

@Hawazyn Hawazyn marked this pull request as draft December 24, 2024 18:36
- Upgraded base OS versions and dependencies to their latest stable releases.
- Improved build processes:
  - Applied `apk add --no-cache` and `apt-get install --no-install-recommends` for efficient installations.
  - Ensured cleanup after installations to reduce image size.
  - Replaced `apt` with `apt-get` for consistency.

- Enhanced maintainability:
  - Introduced `WORKDIR` for better path management.
  - Quoted variables to avoid word splitting and potential errors.
  - Updated `ENV` instructions to use `key=value` format, resolving deprecation warnings.

- Removed obsolete and redundant components:
  - The `version` attribute from Docker Compose files, resolving warnings.
  - Unnecessary `DEBIAN_FRONTEND=noninteractive` from Alpine images.
  - Redundant upgrade steps during package installations.

- OpenSSH:
  - Fixed `/etc/profile.d/README` errors caused by invalid commands and syntax issues.
  - Customized the OpenSSH setup with a clean and informative welcome message.

Exclusions: These changes exclude the OpenSSL 3 Dockerfile and nginx/fulltest/dockerfile.
Signed-off-by: Khalid <187553667+itsHayyaf@users.noreply.github.com>
@Hawazyn
Copy link
Contributor Author

Hawazyn commented Dec 25, 2024

@ajbozarth @davidgca Would you mind looking into the issues with the Mosquitto and Locust CI pipelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant