Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address docker build warnings #325

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

ajbozarth
Copy link
Member

When building, docker throws the following warning:

The 'as' keyword should match the case of the 'from' keyword:
FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

This came up as warning annotations in GitHub Actions in #321

When building docker throws the following warning:

`FromAsCasing: 'as' and 'FROM' keywords' casing do not match`

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth self-assigned this Nov 26, 2024
@ajbozarth ajbozarth requested a review from baentsch November 26, 2024 02:21
@ajbozarth ajbozarth added the bug Something isn't working label Nov 26, 2024
@hayyaaf
Copy link
Contributor

hayyaaf commented Nov 26, 2024

@ajbozarth Could you assign me the Dockerfile fixes and enhancements? The CI pipeline is quite heavy, and I’ll assist you further with it as well.

@hayyaaf
Copy link
Contributor

hayyaaf commented Nov 28, 2024

Hi @ajbozarth, just following up on the Dockerfile fixes and the CI pipeline. Let me know if I can get started or if you need anything from me.

@hayyaaf
Copy link
Contributor

hayyaaf commented Nov 30, 2024

I understand it’s a holiday, and I hope you’re doing well! I wanted to let you know that I’ve already started working on the Dockerfile fixes and enhancements, continuing from where you left off.

@ajbozarth
Copy link
Member Author

I understand it’s a holiday, and I hope you’re doing well! I wanted to let you know that I’ve already started working on the Dockerfile fixes and enhancements, continuing from where you left off.

I look forward to your PR

@ajbozarth
Copy link
Member Author

@baentsch anything blocking this?

@baentsch baentsch merged commit ed4b911 into open-quantum-safe:main Dec 10, 2024
3 of 6 checks passed
@ajbozarth ajbozarth deleted the dockerwarn branch December 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants