Add defines for OQS version components #2000
Conversation
There was a problem hiding this comment.
I'd think it'd be prudent document (progression and change logic of) these defines somewhere such as for users to know what they can rely on (e.g., is "OQS_VERSION_PRE_RELEASE" undefined an indication of a release?). Unsure where to best place it, though: Maybe in "CONFIGURE.md" or as comment atop "oqs.h"?
I've now added documentation comments in |
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com> Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com> Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
dstebila
force-pushed
the
ds-version-defines
branch
from
cba50f9 to
33065bc
Compare
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
Fixes #1993.
Note that I had to use
#definerather than#cmakedefinein oqsconfig.h.cmake to avoid it not setting the macros when the values are equal to a false-y value like0or"".