Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make random/functions deterministic during fuzzing #1974

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Make random/functions deterministic during fuzzing #1974

merged 1 commit into from
Nov 3, 2024

Conversation

nathaniel-brough
Copy link
Contributor

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@nathaniel-brough
Make random/functions determinisitic during fuzzing
9062a9c 
Signed-off-by: Nathaniel Brough <nathaniel.brough@gmail.com>
baentsch
baentsch reviewed Nov 3, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM with a single comment/question.

@dstebila dstebila merged commit 35cc700 into open-quantum-safe:main Nov 3, 2024
73 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathaniel-brough @dstebila @baentsch