-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #1943
Update CODEOWNERS #1943
Conversation
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Github complains about users in this revised CODEOWNERS file not having write access. We'll have to decide whether to add those people in the TSC config.yaml file or whether to remove them from CODEOWNERS. |
If we're planning on using the CODEOWNERS file to track code ownership and assign reviews, then I think it makes sense to update config.yaml to add the necessary people to the codeowners team. I will create a draft PR tracking this one in the TSC repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve but recommend we hold merge until open-quantum-safe/tsc#88 lands so as to not invalidate the CODEOWNERS file.
Shall we merge this? |
I vote yes now that open-quantum-safe/tsc#88 has landed. |
Updates Github CODEOWNERS file to reflect more recent active contributors. I've probably missed people, so please make a comment or add to the PR to fix.
Fixes #1843.