Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #1943

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update CODEOWNERS #1943

merged 2 commits into from
Oct 23, 2024

Conversation

dstebila
Copy link
Member

@dstebila dstebila commented Oct 1, 2024

Updates Github CODEOWNERS file to reflect more recent active contributors. I've probably missed people, so please make a comment or add to the PR to fix.

Fixes #1843.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [No] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
@dstebila dstebila self-assigned this Oct 1, 2024
@dstebila dstebila requested review from SWilson4 and baentsch October 1, 2024 00:18
@dstebila
Copy link
Member Author

dstebila commented Oct 1, 2024

Github complains about users in this revised CODEOWNERS file not having write access. We'll have to decide whether to add those people in the TSC config.yaml file or whether to remove them from CODEOWNERS.

@SWilson4
Copy link
Member

SWilson4 commented Oct 1, 2024

Github complains about users in this revised CODEOWNERS file not having write access. We'll have to decide whether to add those people in the TSC config.yaml file or whether to remove them from CODEOWNERS.

If we're planning on using the CODEOWNERS file to track code ownership and assign reviews, then I think it makes sense to update config.yaml to add the necessary people to the codeowners team. I will create a draft PR tracking this one in the TSC repo.

Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but recommend we hold merge until open-quantum-safe/tsc#88 lands so as to not invalidate the CODEOWNERS file.

@dstebila dstebila marked this pull request as ready for review October 22, 2024 17:07
@dstebila
Copy link
Member Author

Shall we merge this?

@SWilson4
Copy link
Member

Shall we merge this?

I vote yes now that open-quantum-safe/tsc#88 has landed.

@dstebila dstebila merged commit 7132473 into main Oct 23, 2024
81 checks passed
@dstebila dstebila deleted the ds-update-codeowners branch October 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CODEOWNERS
3 participants