-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed build wrapper script for static libs macOS / iOS / Android platforms #1717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to close as per open-quantum-safe/oqs-provider#363 (comment). Tagging @dstebila @andybrucenet for additional feedback.
Closing, cf. open-quantum-safe/oqs-provider#363 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wish to integrate kyber and other algorithms in our apps via oqs-provider - and this requires a built liboqs foreach of our cross-compiled solutions in addition to a built openssl.
The script has the following features:
build/apple/iphoneos/arm64
orbuild/android/arm64-v8a
).build/export
in a versioned format; example:build/export/android/0.10.0-dev/armeabi-v7a/lib
.#defines
the output includes headers for each platform. Example:build/export/apple/0.10.0-dev/macosx/arm64/include
The output from the script can be used as-is with the analogous script for the
oqs-provider
project - there is a separate PR for that project.No
No new features added. The script requires access to a versioned openssl with subfolders to each platform.
Examples:
[dir]/android/3.2.1
with subfolders similar toarm64-v8a/{include,lib}
[dir]/apple/3.2.1
with subfolders similar toiphoneos/{include,lib}