-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Falcon PADDED format #1710
Conversation
9e3fa74
to
916cfed
Compare
@Frauschi Can you please take a look at the Zephyr test failure? It looks like an out-of-storage error to me, and I'm unsure of the best way to resolve it. The same test fails on the current |
The |
Indeed, what does "No space left on device" mean in this context? Also FYI, @Frauschi we're aiming of doing a |
I just created PR #1714 that should fix the failing Zephyr CI tests. The problem was the Zephyr installation that has been created within the test environment. A default Zephyr installation is several GBs in size, apparently overfilling the disk space of the Github runner. Hence, the "No space left on device". |
c725dfb
to
9cd201d
Compare
b952262
to
62bb72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this work, @SWilson4 !
@@ -13,8 +13,8 @@ upstreams: | |||
- | |||
name: pqclean | |||
git_url: https://github.com/PQClean/PQClean.git | |||
git_branch: master | |||
git_commit: 0657749a785db30e7f49e9435452cb042edb1852 | |||
git_branch: sw-falcon-padded-rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as reminder: This needs changing before final merge.
Additionally: - re-enable Falcon-1024 in weekly KAT tests - Update Falcon licence documentation - Update deprecated CircleCI image Signed-off-by: Eddy Kim <Eddy.M.Kim@outlook.com>
Support the fixed-size PADDED format for Falcon signatures and update the existing Falcon code (which intends to implements the COMPRESSED format) to bring it in line with the spec. Reenable Falcon-1024 in weekly extended KAT tests, as it should now pass.
A couple of points to make review simpler:
api.h
andpqclean.c
. It's probably worth looking at a side-by-side diff of these: for example,pqclean_falcon-512-padded_clean/pqclean.c
vspqclean_falcon-512_clean/pqclean.c
.Fixes #1561 and #1608.