Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PQClean commit 5b8ef3baea3ffdfbf688a3a1bb8f02de44a67ec0 #1097

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Update to PQClean commit 5b8ef3baea3ffdfbf688a3a1bb8f02de44a67ec0 #1097

merged 2 commits into from
Oct 1, 2021

Conversation

dstebila
Copy link
Member

Fixes #1035. Fixes #1036.

@dstebila dstebila added the bug Something isn't working; high priority to fix label Sep 30, 2021
@dstebila dstebila self-assigned this Sep 30, 2021
@dstebila dstebila marked this pull request as ready for review September 30, 2021 20:34
baentsch
baentsch requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .md files do not seem to be not updated, which is arguably important as some claimed NIST levels changed: Did scripts/update_docs_from_yaml.py run?

@dstebila
Copy link
Member Author

dstebila commented Oct 1, 2021

The .md files do not seem to be not updated, which is arguably important as some claimed NIST levels changed: Did scripts/update_docs_from_yaml.py run?

I did run it but couldn't seem to get it to have an effect. Can you try?

@baentsch
Copy link
Member

baentsch commented Oct 1, 2021

Can you try?

Done. Worked as advertised. Please check the results.

@dstebila
Copy link
Member Author

dstebila commented Oct 1, 2021

Can you try?

Done. Worked as advertised. Please check the results.

Thanks Michael!

@dstebila dstebila merged commit 36d8a49 into main Oct 1, 2021
@dstebila dstebila deleted the gcc11-fixes branch October 1, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch requested changes

@bhess bhess Awaiting requested review from bhess bhess is a code owner

@jschanck jschanck Awaiting requested review from jschanck

@xvzcf xvzcf Awaiting requested review from xvzcf

Assignees

@dstebila dstebila

Labels
bug Something isn't working; high priority to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

McEliece also has problems with GCC 11.1.0 Many schemes fail to compile with GCC 11.1.0
2 participants
@dstebila @baentsch