Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding armv8 crypto extensions to AES #1086

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Adding armv8 crypto extensions to AES #1086

merged 5 commits into from
Sep 15, 2021

Conversation

tedeaton
Copy link
Contributor

@tedeaton tedeaton commented Sep 9, 2021

Adds armv8 crypto extension to AES, similar to #1052.

  • Adds additional files to CMakeLists.txt
  • Changes tests/system_info.c to describe if arm extensions are used for AES
  • Generalizes the C_OR_NI macro in src/common/aes/aes.c and tests/system_info.c to C_OR_NI_OR_ARM
  • input / output behaviour is not changes
  • algorithms available does not change

@baentsch
Copy link
Member

FWIW: If you want to get AppVeyor to pass (by using an old gcc), you may want to (temporarily, until #1035 is fixed) replace

c:\cygwin64\bin\bash.exe -lc "setup-x86_64.exe -qnNdO -R C:/cygwin64 -l C:/cygwin/var/cache/setup -P openssl -P libssl-devel -P ninja -P cmake -P gcc ...

with

c:\cygwin64\bin\bash.exe -lc "setup-x86_64.exe -qnNdO -R C:/cygwin64 -l C:/cygwin/var/cache/setup -P openssl -P libssl-devel -P ninja -P cmake -P gcc-core=9.3.0-2 ...

in appveyor_build.bat.

@dstebila dstebila marked this pull request as ready for review September 15, 2021 18:43
@dstebila dstebila merged commit 001a3aa into open-quantum-safe:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants