Updated SIKE to latest upstream commit #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
LGTM: Issue resolved, references and docs updated, all tests passed.
Somewhat related and after checking the upstream reference (incl. the M1 support), may I ask what speaks against adding the "FAST" build option too when importing the code to liboqs? It would be great to have it for more representative profiling results.
Optimizations enabled by the FAST upstream makefile option have been mapped to our build system's optimizations. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SIKE to upstream commit effa60, addressing issue 1056: replaces
__inlinewithinline; upstream also catches up to some changes already in OQS (for Apple M1 support).Fixes #1056.