Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #16

Merged
merged 1 commit into from
May 28, 2021
Merged

Update README.md #16

merged 1 commit into from
May 28, 2021

Conversation

wangweij
Copy link
Contributor

Classic-McEliece (and some other algorithms) uses a large stack when generating key pairs. The default 1M stack size for Java is not enough.

@wangweij
Update README.md
7de2268 
Classic-McEliece (and some other algorithms) uses a large stack when generating key pairs. The default 1M stack size for Java is not enough.
@dstebila dstebila merged commit 33a0680 into open-quantum-safe:master May 28, 2021
@dstebila
Copy link
Member

Thanks for the note!

@wangweij wangweij deleted the patch-1 branch May 28, 2021 15:15
jimouris
jimouris reviewed May 28, 2021
View reviewed changes
Copy link
Member

@jimouris jimouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in pom.xml but is useful to have on the README as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimouris jimouris jimouris left review comments

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangweij @dstebila @jimouris