Guard Google UT update and correction #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Unit Test cases for guard repo has been updated and corrected to latest ***************** TEST RESULTS ***************** [==========] Running 15 tests from 1 test suite. [----------] Global test environment set-up. [----------] 15 tests from TestGuardRecord [ RUN ] TestGuardRecord.CreateGuardRecord [ OK ] TestGuardRecord.CreateGuardRecord (0 ms) [ RUN ] TestGuardRecord.ClearGuardGoodPathTest [ OK ] TestGuardRecord.ClearGuardGoodPathTest (0 ms) [ RUN ] TestGuardRecord.DeleteGuardGoodPathTest [ OK ] TestGuardRecord.DeleteGuardGoodPathTest (1 ms) [ RUN ] TestGuardRecord.NegTestCaseEP [ OK ] TestGuardRecord.NegTestCaseEP (0 ms) [ RUN ] TestGuardRecord.NegTestCaseFullGuardFile Guard file size is 656b (in bytes) and space remaining in the GUARD file is 0b but, required 128b to create a record. Total records: 5 [ OK ] TestGuardRecord.NegTestCaseFullGuardFile (1 ms) [ RUN ] TestGuardRecord.AlreadyGuardedTC Failed to overwrite since record is already exist and that does not meet the condition to overwrite [ OK ] TestGuardRecord.AlreadyGuardedTC (0 ms) [ RUN ] TestGuardRecord.GetCreatedGuardRecordTC [ OK ] TestGuardRecord.GetCreatedGuardRecordTC (0 ms) [ RUN ] TestGuardRecord.DeleteByEntityPath [ OK ] TestGuardRecord.DeleteByEntityPath (0 ms) [ RUN ] TestGuardRecord.DeleteWithNotExistentEntity Guard record not found [ OK ] TestGuardRecord.DeleteWithNotExistentEntity (0 ms) [ RUN ] TestGuardRecord.DeleteByRecordId [ OK ] TestGuardRecord.DeleteByRecordId (0 ms) [ RUN ] TestGuardRecord.DeleteWithNotExistentRecordId Guard record not found [ OK ] TestGuardRecord.DeleteWithNotExistentRecordId (0 ms) [ RUN ] TestGuardRecord.GetGuardFilePathTC [ OK ] TestGuardRecord.GetGuardFilePathTC (0 ms) [ RUN ] TestGuardRecord.GetGuardFilePathWhenLibguradDidNotInitTC Guard file is not initialised. [ OK ] TestGuardRecord.GetGuardFilePathWhenLibguradDidNotInitTC (0 ms) [ RUN ] TestGuardRecord.ClearGuardInvalidateAllPathTest [ OK ] TestGuardRecord.ClearGuardInvalidateAllPathTest (0 ms) [ RUN ] TestGuardRecord.ClearResolvedGuardRecord [ OK ] TestGuardRecord.ClearResolvedGuardRecord (1 ms) [----------] 15 tests from TestGuardRecord (8 ms total) [----------] Global test environment tear-down [==========] 15 tests from 1 test suite ran. (8 ms total) [ PASSED ] 15 tests. ============================================================================== Ok: 1 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 0 Timeout: 0 Signed-off-by: swarnendu.roy.chowdhury@ibm.com
dhruvibm
reviewed
Jun 17, 2023
deepakala-k
reviewed
Jul 5, 2023
| phyPath = "/sys-0/node-0/proc-0/eq-0/fc-0/core-1"; | ||
| entityPath = openpower::guard::getEntityPath(phyPath); | ||
| openpower::guard::create(*entityPath); | ||
| LibGuardInit("/sys-0/node-0/proc-1/eq-0/fc-0/core-0"); |
There was a problem hiding this comment.
Here the libguard Init gets called 4 times whereas it was only called once earlier. Better to avoid it
deepakala-k
reviewed
Jul 5, 2023
| phyPath = "/sys-0/node-0/dimm-1"; | ||
| entityPath = openpower::guard::getEntityPath(phyPath); | ||
| EXPECT_THROW({ openpower::guard::create(*entityPath); }, | ||
| LibGuardInit("/sys-0/node-0/proc-1/eq-0/fc-0/core-0"); |
There was a problem hiding this comment.
Same as earlier comment
deepakala-k
reviewed
Jul 5, 2023
| phyPath = "/sys-0/node-0/dimm-3"; | ||
| entityPath = openpower::guard::getEntityPath(phyPath); | ||
| openpower::guard::create(*entityPath); | ||
| LibGuardInit("/sys-0/node-0/dimm-0"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Unit Test cases for guard repo has been updated and corrected to latest
TEST RESULTS
[==========] Running 15 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 15 tests from TestGuardRecord
[ RUN ] TestGuardRecord.CreateGuardRecord
[ OK ] TestGuardRecord.CreateGuardRecord (0 ms)
[ RUN ] TestGuardRecord.ClearGuardGoodPathTest
[ OK ] TestGuardRecord.ClearGuardGoodPathTest (0 ms)
[ RUN ] TestGuardRecord.DeleteGuardGoodPathTest
[ OK ] TestGuardRecord.DeleteGuardGoodPathTest (1 ms)
[ RUN ] TestGuardRecord.NegTestCaseEP
[ OK ] TestGuardRecord.NegTestCaseEP (0 ms)
[ RUN ] TestGuardRecord.NegTestCaseFullGuardFile
Guard file size is 656b (in bytes) and space remaining in the GUARD file is 0b but, required 128b to create a record. Total records: 5
[ OK ] TestGuardRecord.NegTestCaseFullGuardFile (1 ms)
[ RUN ] TestGuardRecord.AlreadyGuardedTC
Failed to overwrite since record is already exist and that does not meet the condition to overwrite
[ OK ] TestGuardRecord.AlreadyGuardedTC (0 ms)
[ RUN ] TestGuardRecord.GetCreatedGuardRecordTC
[ OK ] TestGuardRecord.GetCreatedGuardRecordTC (0 ms)
[ RUN ] TestGuardRecord.DeleteByEntityPath
[ OK ] TestGuardRecord.DeleteByEntityPath (0 ms)
[ RUN ] TestGuardRecord.DeleteWithNotExistentEntity
Guard record not found
[ OK ] TestGuardRecord.DeleteWithNotExistentEntity (0 ms)
[ RUN ] TestGuardRecord.DeleteByRecordId
[ OK ] TestGuardRecord.DeleteByRecordId (0 ms)
[ RUN ] TestGuardRecord.DeleteWithNotExistentRecordId
Guard record not found
[ OK ] TestGuardRecord.DeleteWithNotExistentRecordId (0 ms)
[ RUN ] TestGuardRecord.GetGuardFilePathTC
[ OK ] TestGuardRecord.GetGuardFilePathTC (0 ms)
[ RUN ] TestGuardRecord.GetGuardFilePathWhenLibguradDidNotInitTC
Guard file is not initialised.
[ OK ] TestGuardRecord.GetGuardFilePathWhenLibguradDidNotInitTC (0 ms)
[ RUN ] TestGuardRecord.ClearGuardInvalidateAllPathTest
[ OK ] TestGuardRecord.ClearGuardInvalidateAllPathTest (0 ms)
[ RUN ] TestGuardRecord.ClearResolvedGuardRecord
[ OK ] TestGuardRecord.ClearResolvedGuardRecord (1 ms)
[----------] 15 tests from TestGuardRecord (8 ms total)
[----------] Global test environment tear-down
[==========] 15 tests from 1 test suite ran. (8 ms total) [ PASSED ] 15 tests.
Ok: 1
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Signed-off-by: swarnendu.roy.chowdhury@ibm.com