Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump the go-opentelemetry-io group with 3 updates #6535

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 19, 2024

Bumps the go-opentelemetry-io group with 3 updates: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp, go.opentelemetry.io/otel/exporters/otlp/otlptrace and go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc.

Updates go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.46.1 to 0.47.0

Release notes

Sourced from go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp's releases.

Release 1.22.0/0.47.0/0.16.0/0.2.0

Added

  • Add SDK.Shutdown method in "go.opentelemetry.io/contrib/config". (#4583)
  • NewSDK in go.opentelemetry.io/contrib/config now returns a configured SDK with a valid TracerProvider. (#4741)

Changed

  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/example are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/example are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/otelhttpare upgraded to v1.20.0. (#4320)
  • Updated configuration schema to include schema_url for resource definition and without_type_suffix and without_units for the Prometheus exporter. (#4727)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/ecs resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/lambda resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/ec2 resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/eks resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/gcp resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/test are upgraded to v1.24.0. (#4803)

Fixed

  • Fix NewServerHandler in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to correctly set the span status depending on the gRPC status. (#4587)
  • The stats.Handler from go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc now does not crash when receiving an unexpected context. (#4825)
  • Update go.opentelemetry.io/contrib/detectors/aws/ecs to fix the task ARN when it is not valid. (#3583)
  • Do not panic in go.opentelemetry.io/contrib/detectors/aws/ecs when the container ARN is not valid. (#3583)

Release v1.21.1/v0.46.1/v0.15.1/v0.1.1

Changed

Fixed

  • Fix StreamClientInterceptor in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to end the spans synchronously. (#4537)
  • Fix data race in stats handlers when processing messages received and sent metrics in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#4577)
  • The stats handlers NewClientHandler, NewServerHandler in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc now record RPC durations in ms instead of ns. (#4548)

Release v1.21.0/v0.46.0/v0.15.0/v0.1.0

Added

  • Add the new go.opentelemetry.io/contrib/instrgen package to provide auto-generated source code instrumentation. (#3068, #3108)
  • Add "go.opentelemetry.io/contrib/samplers/jaegerremote".WithSamplingStrategyFetcher which sets custom fetcher implementation. (#4045)
  • Add "go.opentelemetry.io/contrib/config" package that includes configuration models generated via go-jsonschema. (#4376)
  • Add NewSDK function to "go.opentelemetry.io/contrib/config". The initial implementation only returns noop providers. (#4414)

... (truncated)

Changelog

Sourced from go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp's changelog.

[1.22.0/0.47.0/0.16.0/0.2.0] - 2024-01-18

Added

  • Add SDK.Shutdown method in "go.opentelemetry.io/contrib/config". (#4583)
  • NewSDK in go.opentelemetry.io/contrib/config now returns a configured SDK with a valid TracerProvider. (#4741)

Changed

  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/example are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/example are upgraded to v1.20.0. (#4320)
  • The semantic conventions used by go.opentelemetry.io/contrib/instrumentation/net/http/otelhttpare upgraded to v1.20.0. (#4320)
  • Updated configuration schema to include schema_url for resource definition and without_type_suffix and without_units for the Prometheus exporter. (#4727)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/ecs resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/lambda resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/ec2 resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/aws/eks resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used by the go.opentelemetry.io/contrib/detectors/gcp resource detector are upgraded to v1.24.0. (#4803)
  • The semantic conventions used in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/test are upgraded to v1.24.0. (#4803)

Fixed

  • Fix NewServerHandler in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to correctly set the span status depending on the gRPC status. (#4587)
  • The stats.Handler from go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc now does not crash when receiving an unexpected context. (#4825)
  • Update go.opentelemetry.io/contrib/detectors/aws/ecs to fix the task ARN when it is not valid. (#3583)
  • Do not panic in go.opentelemetry.io/contrib/detectors/aws/ecs when the container ARN is not valid. (#3583)
Commits
  • 044e09a Release 1.22.0/0.47.0/0.16.0/0.2.0 (#4827)
  • 40290ea [instrumentation/google.golang.org/grpc/otelgrpc] Do not assume HandleRPC rec...
  • a28c68b otelgrpc: Remove withoutContext (#4705)
  • 96790b3 dependabot updates Tue Jan 16 18:26:09 UTC 2024 (#4823)
  • ffc47ec Bump detector semconv to v1.24.0 (#4803)
  • 0a02c5b config: NewSDK can return valid TracerProvider (#4741)
  • 3cecdcf build(deps): bump github.com/cloudflare/circl in /tools (#4800)
  • ef26c0a dependabot updates Sun Jan 7 23:23:57 UTC 2024 (#4798)
  • f16553c otelgrpc: Remove code that has no effects in stats handlers (#4773)
  • f770d88 dependabot updates Mon Jan 1 11:23:34 UTC 2024 (#4778)
  • Additional commits viewable in compare view

Updates go.opentelemetry.io/otel/exporters/otlp/otlptrace from 1.21.0 to 1.22.0

Changelog

Sourced from go.opentelemetry.io/otel/exporters/otlp/otlptrace's changelog.

[1.22.0/0.45.0] 2024-01-17

Added

  • The go.opentelemetry.io/otel/semconv/v1.22.0 package. The package contains semantic conventions from the v1.22.0 version of the OpenTelemetry Semantic Conventions. (#4735)
  • The go.opentelemetry.io/otel/semconv/v1.23.0 package. The package contains semantic conventions from the v1.23.0 version of the OpenTelemetry Semantic Conventions. (#4746)
  • The go.opentelemetry.io/otel/semconv/v1.23.1 package. The package contains semantic conventions from the v1.23.1 version of the OpenTelemetry Semantic Conventions. (#4749)
  • The go.opentelemetry.io/otel/semconv/v1.24.0 package. The package contains semantic conventions from the v1.24.0 version of the OpenTelemetry Semantic Conventions. (#4770)
  • Add WithResourceAsConstantLabels option to apply resource attributes for every metric emitted by the Prometheus exporter. (#4733)
  • Experimental cardinality limiting is added to the metric SDK. See metric documentation for more information about this feature and how to enable it. (#4457)
  • Add NewMemberRaw and NewKeyValuePropertyRaw in go.opentelemetry.io/otel/baggage. (#4804)

Changed

  • Upgrade all use of go.opentelemetry.io/otel/semconv to use v1.24.0. (#4754)
  • Update transformations in go.opentelemetry.io/otel/exporters/zipkin to follow v1.19.0 version of the OpenTelemetry specification. (#4754)
  • Record synchronous measurements when the passed context is canceled instead of dropping in go.opentelemetry.io/otel/sdk/metric. If you do not want to make a measurement when the context is cancelled, you need to handle it yourself (e.g if ctx.Err() != nil). (#4671)
  • Improve go.opentelemetry.io/otel/trace.TraceState's performance. (#4722)
  • Improve go.opentelemetry.io/otel/propagation.TraceContext's performance. (#4721)
  • Improve go.opentelemetry.io/otel/baggage performance. (#4743)
  • Improve performance of the (*Set).Filter method in go.opentelemetry.io/otel/attribute when the passed filter does not filter out any attributes from the set. (#4774)
  • Member.String in go.opentelemetry.io/otel/baggage percent-encodes only when necessary. (#4775)
  • Improve go.opentelemetry.io/otel/trace.Span's performance when adding multiple attributes. (#4818)
  • Property.Value in go.opentelemetry.io/otel/baggage now returns a raw string instead of a percent-encoded value. (#4804)

Fixed

  • Fix Parse in go.opentelemetry.io/otel/baggage to validate member value before percent-decoding. (#4755)
  • Fix whitespace encoding of Member.String in go.opentelemetry.io/otel/baggage. (#4756)
  • Fix observable not registered error when the asynchronous instrument has a drop aggregation in go.opentelemetry.io/otel/sdk/metric. (#4772)
  • Fix baggage item key so that it is not canonicalized in go.opentelemetry.io/otel/bridge/opentracing. (#4776)
  • Fix go.opentelemetry.io/otel/bridge/opentracing to properly handle baggage values that requires escaping during propagation. (#4804)
  • Fix a bug where using multiple readers resulted in incorrect asynchronous counter values in go.opentelemetry.io/otel/sdk/metric. (#4742)
Commits
  • 279c549 Release v1.22.0/v0.45.0 (#4821)
  • 237ed37 Fix link changes from instrumentation to languages (#4828)
  • 5ed29d9 Bump lycheeverse/lychee-action from 1.9.0 to 1.9.1 (#4824)
  • 4491b39 sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() (#4818)
  • 19622d3 chore(docs): explicitly mark lizthegrey emeritus (#4822)
  • 7fa7d1b sdk/metric: Fix observable not registered error when the asynchronous instrum...
  • 01472db Upgrade use of semconv to v1.24.0 (#4754)
  • 259143a baggage: Add NewMemberRaw and NewKeyValuePropertyRaw (#4804)
  • 6ead8d8 Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 in /internal/tools (#4815)
  • deddec3 Optimize (attribute.Set).Filter for no filtered case (#4774)
  • Additional commits viewable in compare view

Updates go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.21.0 to 1.22.0

Changelog

Sourced from go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc's changelog.

[1.22.0/0.45.0] 2024-01-17

Added

  • The go.opentelemetry.io/otel/semconv/v1.22.0 package. The package contains semantic conventions from the v1.22.0 version of the OpenTelemetry Semantic Conventions. (#4735)
  • The go.opentelemetry.io/otel/semconv/v1.23.0 package. The package contains semantic conventions from the v1.23.0 version of the OpenTelemetry Semantic Conventions. (#4746)
  • The go.opentelemetry.io/otel/semconv/v1.23.1 package. The package contains semantic conventions from the v1.23.1 version of the OpenTelemetry Semantic Conventions. (#4749)
  • The go.opentelemetry.io/otel/semconv/v1.24.0 package. The package contains semantic conventions from the v1.24.0 version of the OpenTelemetry Semantic Conventions. (#4770)
  • Add WithResourceAsConstantLabels option to apply resource attributes for every metric emitted by the Prometheus exporter. (#4733)
  • Experimental cardinality limiting is added to the metric SDK. See metric documentation for more information about this feature and how to enable it. (#4457)
  • Add NewMemberRaw and NewKeyValuePropertyRaw in go.opentelemetry.io/otel/baggage. (#4804)

Changed

  • Upgrade all use of go.opentelemetry.io/otel/semconv to use v1.24.0. (#4754)
  • Update transformations in go.opentelemetry.io/otel/exporters/zipkin to follow v1.19.0 version of the OpenTelemetry specification. (#4754)
  • Record synchronous measurements when the passed context is canceled instead of dropping in go.opentelemetry.io/otel/sdk/metric. If you do not want to make a measurement when the context is cancelled, you need to handle it yourself (e.g if ctx.Err() != nil). (#4671)
  • Improve go.opentelemetry.io/otel/trace.TraceState's performance. (#4722)
  • Improve go.opentelemetry.io/otel/propagation.TraceContext's performance. (#4721)
  • Improve go.opentelemetry.io/otel/baggage performance. (#4743)
  • Improve performance of the (*Set).Filter method in go.opentelemetry.io/otel/attribute when the passed filter does not filter out any attributes from the set. (#4774)
  • Member.String in go.opentelemetry.io/otel/baggage percent-encodes only when necessary. (#4775)
  • Improve go.opentelemetry.io/otel/trace.Span's performance when adding multiple attributes. (#4818)
  • Property.Value in go.opentelemetry.io/otel/baggage now returns a raw string instead of a percent-encoded value. (#4804)

Fixed

  • Fix Parse in go.opentelemetry.io/otel/baggage to validate member value before percent-decoding. (#4755)
  • Fix whitespace encoding of Member.String in go.opentelemetry.io/otel/baggage. (#4756)
  • Fix observable not registered error when the asynchronous instrument has a drop aggregation in go.opentelemetry.io/otel/sdk/metric. (#4772)
  • Fix baggage item key so that it is not canonicalized in go.opentelemetry.io/otel/bridge/opentracing. (#4776)
  • Fix go.opentelemetry.io/otel/bridge/opentracing to properly handle baggage values that requires escaping during propagation. (#4804)
  • Fix a bug where using multiple readers resulted in incorrect asynchronous counter values in go.opentelemetry.io/otel/sdk/metric. (#4742)
Commits
  • 279c549 Release v1.22.0/v0.45.0 (#4821)
  • 237ed37 Fix link changes from instrumentation to languages (#4828)
  • 5ed29d9 Bump lycheeverse/lychee-action from 1.9.0 to 1.9.1 (#4824)
  • 4491b39 sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() (#4818)
  • 19622d3 chore(docs): explicitly mark lizthegrey emeritus (#4822)
  • 7fa7d1b sdk/metric: Fix observable not registered error when the asynchronous instrum...
  • 01472db Upgrade use of semconv to v1.24.0 (#4754)
  • 259143a baggage: Add NewMemberRaw and NewKeyValuePropertyRaw (#4804)
  • 6ead8d8 Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 in /internal/tools (#4815)
  • deddec3 Optimize (attribute.Set).Filter for no filtered case (#4774)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the go-opentelemetry-io group with 3 updates: [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib), [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) and [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go).


Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.46.1 to 0.47.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.46.1...zpages/v0.47.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-opentelemetry-io
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-opentelemetry-io
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: go-opentelemetry-io
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 19, 2024
@johanfylling
Copy link
Contributor

Looks like http.flavor has been replaced by net.protocol.version, which causes test failures. Should we consider this a breaking change?

@ashutosh-narkar
Copy link
Member

Looks like http.flavor has been replaced by net.protocol.version, which causes test failures. Should we consider this a breaking change?

I think so. We'll have to update the tests. Is there a link we can point to which mentions http.flavor has been replaced by net.protocol.version?

@johanfylling
Copy link
Contributor

The mentions I can find is this issue in opentelemetry-specification that was merged in the summer of last year; and there is this blog post. I don't see a direct path from there to these library bumps, however.

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit dcc35fd
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/65afdcd71abfd70008d61a77
😎 Deploy Preview https://deploy-preview-6535--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes. What do your say @ashutosh-narkar ?

@@ -91,10 +91,11 @@ func TestServerSpan(t *testing.T) {
attribute.Int("net.host.port", port),
attribute.String("http.method", "POST"),
attribute.String("http.scheme", "http"),
attribute.String("http.flavor", "1.1"),
attribute.String("net.protocol.version", "1.1"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http.flavor->net.protocol.version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this, net.protocol.version is now network.protocol.version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I saw. But that's not part of this version bump. Maybe it'll come as an additional breaking change in a future release ..

attribute.Int("http.status_code", 200),
attribute.String("http.user_agent", "Go-http-client/1.1"),
attribute.String("user_agent.original", "Go-http-client/1.1"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http.user_agent->user_agent.original

Signed-off-by: Johan Fylling <johan.dev@fylling.se>
@ashutosh-narkar
Copy link
Member

Closing this PR as there seem to be additional breaking changes that are likely to be part of the next release or so and it would be better to get all of them merged together.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants