refact: unify get headers approach from a decision #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regeda
force-pushed
the
unify-get-headers-func
branch
3 times, most recently
from
1d5f0ae to
e45b16a
Compare
regeda
force-pushed
the
unify-get-headers-func
branch
5 times, most recently
from
ea1412f to
35b72c0
Compare
srenatus
previously approved these changes
Jan 8, 2025
Both `headers` and `response_headers_to_add` attributes returned by the same function. Remove intermediate http.Header transformation between decision output and Envoy headers. Signed-off-by: Anthony Regeda <regedaster@gmail.com>
regeda
force-pushed
the
unify-get-headers-func
branch
from
35b72c0 to
1c584d0
Compare
srenatus
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
headersandresponse_headers_to_addattributes returned by the same function.Remove intermediate
http.Headertransformation between decision output and Envoy headers.