issue-6333 pass input to log even if check request times out #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
pass_input_checkrequest_timeout
branch
from
1af6ac8 to
23aa452
Compare
internal/internal.go
Outdated
| @@ -400,6 +395,11 @@ func (p *envoyExtAuthzGrpcServer) check(ctx context.Context, req interface{}) (* | |||
| return nil, stop, err | |||
| } | |||
|
|
|||
| if ctx.Err() != nil { | |||
There was a problem hiding this comment.
We can move this before we convert to ast.Value correct ? We only need the input map to be non-nil.
There was a problem hiding this comment.
@ashutosh-narkar right, moved it to immediately after parsing input.
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
pass_input_checkrequest_timeout
branch
from
23aa452 to
8ce192b
Compare
ashutosh-narkar
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-policy-agent/opa#6333