docs: Update mutation assign doc #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anlan Du <adu47249@gmail.com>
anlandu
changed the title
|
It may have been the case that originally the pathTest guidance was directly above the Assign example--this Assign seems to be the one being referenced when that section refers to "the example below." I can update the wording there if my interepretation is correct. But IMO the example should still have the pathTest: people will copy-paste expecting it to work out of box rather than expect that it includes a footgun followed by a fix for it in a separate code snippet |
David-Jaeyoon-Lee
pushed a commit
to David-Jaeyoon-Lee/gatekeeper
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Anlan Du <adu47249@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the demo-privileged Assign is applied out of the box on a cluster, it will cause pods lacking a container "foo" to fail schema validation due to creating a new foo container that's missing required information. Update the example to include a pathtest to align with intended behavior.
Special notes for your reviewer: