fix: license lint for container-runtime fork #2854
Conversation
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2854 +/- ##
==========================================
+ Coverage 53.50% 53.51% +0.01%
==========================================
Files 133 133
Lines 11536 11536
==========================================
+ Hits 6172 6174 +2
+ Misses 4887 4885 -2
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if [[ "${GO_PACKAGE}" != k8s.io/* ]]; | ||
| if [[ "${GO_PACKAGE}" == "sigs.k8s.io/controller-runtime" ]] && [[ "${LICENSE_NAME}" == "Apache-2.0" ]]; | ||
| then | ||
| # temporary for our latest fork changes |
There was a problem hiding this comment.
How are we going to enforce the temporary-ness?
There was a problem hiding this comment.
ideally, this goes away with our fork. I can file an issue?
There was a problem hiding this comment.
Might be easier just to leave the test red. It's non-blocking and red tests encourage fixing the underlying issue.
There was a problem hiding this comment.
Issues are much more likely to be auto-closed, particularly if they are not causing active pain.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
This is a left over from #2819 to fix the license lint script by overwriting the license url.
We should make this change as any go.mod change will trigger the
license-lintjob, which will fail without this fixSample failed job today: https://github.com/open-policy-agent/gatekeeper/actions/runs/5294608872/jobs/9584136207