Skip to content

Added namespace to output #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Conversation

rubelw
Copy link
Contributor

@rubelw rubelw commented Oct 16, 2020

No description provided.

@rubelw rubelw force-pushed the master branch 3 times, most recently from 6154387 to 6fc82ff Compare October 16, 2020 15:50
@rubelw
Copy link
Contributor Author

rubelw commented Oct 16, 2020

Fixes #433

  • Table output
    +---------+---------------+-----------------------------+----------------------------------------------+
    | RESULT | FILE | NAMESPACE | MESSAGE |
    +---------+---------------+-----------------------------+----------------------------------------------+
    | failure | ./tfplan.json | namespace1 | aws_s3_bucket.another_bucket |
    | | | | S3 Bucket does not have |
    | | | | server-side encryption enabled |
    | | | | |
    | success | ./tfplan.json | namespace2 | SUCCESS |

  • TAP output

successes
ok 1 - ./tfplan.json - namespace2 - SUCCESS
1..2
not ok 1 - ./tfplan.json - namespace1 - Invalid tags (missing minimum required tags) for the following resources: ["aws_autoscaling_group.my_asg"]

Copy link
Collaborator

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! It is a nice improvement and will really help the multiple namespace usecases. However, the JUnit output needs to be updated as well. Maybe it can be included as part of the TestName?

@rubelw rubelw force-pushed the master branch 2 times, most recently from dfaf237 to 4ae0992 Compare October 19, 2020 14:04
Signed-off-by: Will Rubel <willrubel@gmail.com>
@rubelw
Copy link
Contributor Author

rubelw commented Oct 19, 2020

@Blokje5 Update to include namespace in junit output. Now, junit output will have the namespace appended to the name like so: name="./tfplan.json - artifactory_iac_tier_3_2_4" time="0.000"

Copy link
Collaborator

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Blokje5 Blokje5 merged commit 14d1378 into open-policy-agent:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants