Add linting to CircleCI & to the Makefile. #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blokje5
force-pushed
the
feat/add-linting-to-pipeline
branch
2 times, most recently
from
58c9203 to
bd2238d
Compare
Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
Blokje5
force-pushed
the
feat/add-linting-to-pipeline
branch
from
bd2238d to
a12c0d2
Compare
jpreese
reviewed
Sep 28, 2020
Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
Blokje5
force-pushed
the
feat/add-linting-to-pipeline
branch
from
0686304 to
85e321b
Compare
|
LGTM 🎉 |
jpreese
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure every PR checks go formatting & linting