Change input flag to parser #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to change the
--input
flag to instead, be named--parser
.Reasoning:
The
parser
package exposes a number of different parsers, and these parsers are responsible for parsing different file formats. I feel its currently a little confusing to haveconftest test --input tf
, under the hood this just means to use thehcl2
parser, which we've done a mapping for. Instead, I think it makes more sense to sayconftest test --parser hcl1
orconftest test --parser hcl2
.I do think theres value in being able to figure out which Parser to use, based on a file, which
NewFromPath
accomplishes.This also keeps the language more consistent with what is really happening under the hood, figuring out which parser to use with the given input. As well as keeps the parser package focused on its parsers rather than specific implementations that use the language.