Dockerfile improvements, ARM64 binaries #347
Conversation
Dockerfile
Outdated
| chmod +x /usr/local/bin/kustomize | ||
|
|
||
| RUN go get -u cuelang.org/go/cmd/cue | ||
|
|
||
| WORKDIR /examples | ||
|
|
||
| ## RELEASE ## | ||
| FROM alpine:latest |
There was a problem hiding this comment.
If you could change this back for now. Happy to discuss in a separate issue but it introduces more maintenance overhead from my point of view.
There was a problem hiding this comment.
Sure, changed it back. In general latest makes it harder to reproduce a specific image, that's why I would suggest a proper tagged release.
|
Thanks @mrueg. This looks great. I couple of small things:
|
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
Thanks for the quick review, I've added a note to the docs and added my DCO signoff. |
|
@mrueg thanks, looks good. We'll ship ARM binaries in the next release. The tags only marginally help with reproducibility, as those are ephemeral as well. Using a SHA works, but without better tooling to help maintain it's painful. The tradeoff with latest are worth it for a project like Conftest at the moment. |
This change improves dockerfiles and allows to build conftest binaries for other architectures.