Fix "conftest pull" command's help message #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
KeisukeYamashita
force-pushed
the
fix-pull-help-message
branch
from
188ffd5 to
3f71355
Compare
|
LGTM 🌮 |
jpreese
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I've...
conftest helpcommandGoogle Cloud GCP. AddedGoogle Cloud Storageinstead.Why
Google Cloud GCPis not exactly accurate becauseGCPstands forGoogle Cloud PlatformsoGoogle Cloud GCPwill meanGoogle Cloud Google Cloud Platformwhich is not correct.As I mentioned in #326 , GCP's GCR is one of OCI registries(ref: Container image formats, Google Cloud). Therefore, we can remove it from the help message.
Signed-off-by: KeisukeYamashita 19yamashita15@gmail.com