Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

Client: Fix skill unpacking during bootstrap #2190

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Client: Fix skill unpacking during bootstrap #2190

merged 1 commit into from
Jan 5, 2020

Conversation

dannote
Copy link
Contributor

@dannote dannote commented Jan 5, 2020

Hi there!

I've been trying to launch the compiled runescape-client with my own applet loader and got this exception:

	at BZip2Decompressor.BZip2Decompressor_decompress(BZip2Decompressor.java:197)
	at BZip2Decompressor.BZip2Decompressor_decompress(BZip2Decompressor.java:33)
	at Skills.decompressBytes(Skills.java:51)
	at AbstractArchive.decodeIndex(AbstractArchive.java:100)
	at Archive.write(Archive.java:184)
	at Client.doCycleJs5(Client.java:2611)
	at Client.doCycle(Client.java:1624)
	at GameShell.clientTick(GameShell.java:588)
	at GameShell.run(GameShell.java:916)
	at java.base/java.lang.Thread.run(Thread.java:830)

I compared the code with a previously decompiled version and discovered that this constant should be set to 1. Now everything works fine.

@dannote dannote changed the title Fix skill unpacking during bootstrap Client: Fix skill unpacking during bootstrap Jan 5, 2020
@Lucwousin
Copy link
Contributor

While I don't have any problem merging this, it's fixing a symptom, and not the problem itself, which lays somewhere in the arithmetic part of deobfuscator.

There's also going to be more problems further along the line of running runescape-client, keep that in mind.

@Lucwousin Lucwousin merged commit d980fed into open-osrs:master Jan 5, 2020
@dannote dannote deleted the fix_bzip_decompressor_exception branch January 5, 2020 15:24
@dannote dannote restored the fix_bzip_decompressor_exception branch January 7, 2020 10:07
@Owain94 Owain94 added the bug Something isn't working label Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants