Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

mes: make ShopComparableEntry use standardized string. #2184

Merged
merged 1 commit into from
Jan 3, 2020
Merged

mes: make ShopComparableEntry use standardized string. #2184

merged 1 commit into from
Jan 3, 2020

Conversation

Ganom
Copy link
Contributor

@Ganom Ganom commented Jan 2, 2020

No description provided.

@Ganom Ganom added the bug Something isn't working label Jan 2, 2020
@Lucwousin
Copy link
Contributor

This won't help, the reason it doesn't work is because left clicking will turn Buy 10, Coconut into Buy 10, Buy 10

@Ganom
Copy link
Contributor Author

Ganom commented Jan 2, 2020 •
edited
Loading

This won't help, the reason it doesn't work is because left clicking will turn Buy 10, Coconut into Buy 10, Buy 10

I tested it, and this solved the issue for me. Sell has a color tag on it, since it wasn't being standardized, it wasn't passing the equals check.

Option: "Sell 1<col=ff9040>"
Target: "<col=ff981f>Varrock teleport"

@xKylee
Copy link
Contributor

xKylee commented Jan 3, 2020

quickly testing, will confirm.

@xKylee
Copy link
Contributor

xKylee commented Jan 3, 2020

yup, tested with 10 items and works fine

@xKylee xKylee merged commit cfa501d into open-osrs:master Jan 3, 2020
@Ganom Ganom deleted the fix-shop-compare branch January 4, 2020 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ganom @Lucwousin @xKylee