This repository has been archived by the owner on Apr 8, 2023. It is now read-only.
client: Improve menumanager #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't it work the way it does rn for performance reasons? Iirc we had the capability to do this a while ago but we took it out. |
|
No it was the way it was because menumanager is a pile of yikes and nobody knew why it was really happening or how to fix it. Come to think of it, this can be improved (easily (as easy as changing 3 lines)) so let me do that real quick |
|
I stand corrected |
|
Seems to have broken for me..? smh |
Ganom
previously approved these changes
Nov 13, 2019
Ganom
previously approved these changes
Nov 13, 2019
Ganom
reviewed
Nov 13, 2019
runescape-api/src/main/java/net/runelite/rs/api/RSMenuAction.java
Outdated
Show resolved
Hide resolved
|
noob question, but how do i reverse this commit in my live build |
|
Search in Intellij, Version control, Log tab. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes swaps work all the time, even with really low fps (lol) or when using mousekeys/anything