Fix base reduce_scatter_block for large payloads #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
reviewed
Feb 4, 2022
jjhursey
force-pushed
the
fix-large-payload-reduce-scatter-block
branch
from
5f469aa
to
61120c3
Compare
* Update the four base reduce_scatter_block algorithms to support
large payload collectives.
- The recursive doubling collective fix would have required
changing some ompi_datatype functions which was more extensive
than I wanted to go after in this commit. So if a large payload
is expected in that collective then it falls back to the linear
algorithm.
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
fix-large-payload-reduce-scatter-block
branch
from
61120c3
to
8167468
Compare
bosilca
approved these changes
Feb 12, 2022
|
There should be. It's handled near the top of the function in this block. |
bosilca
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
large payload collectives.
changing some ompi_datatype functions which was more extensive
than I wanted to go after in this commit. So if a large payload
is expected in that collective then it falls back to the linear
algorithm.