-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fortran preprocessor issue with CPPFLAGS #9911
Conversation
* Some C and Fortran compilers use different preprocessors. If one preprocessor accepts `-iquote` and the other does not then a compiler error will occur when Open MPI tries to use it. - Nvidia/PGI v22.1-0 is one such. The C compiler supports `-iquote` while the Fortran compiler does not. * Similar to PR open-mpi#7265 we need to clear the `CPPFLAGS` and `AM_CPPFLAGS` Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit bbe5788)
Humm. A build I kicked off a while ago failed somewhere else on this - just in the v5 branch. I'm cleaning up and rebuilding. There may be more places that need this fix just in the v5 branch. In the meantime, while I'm double checking things I'm going to put a WIP on this. |
It looks like
|
Add missing bits from open-mpi/ompi@ab398f4 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit ca03269)
FYI: My build is finished and all is good with this PR now. It's ready for review. |
Doh. It's on there now. I forgot to push last night. |
accepts
-iquote
and the other does not then a compiler error will occurwhen Open MPI tries to use it.
-iquote
while the Fortran compiler does not.
CPPFLAGS
andAM_CPPFLAGS
Signed-off-by: Joshua Hursey jhursey@us.ibm.com
(cherry picked from commit bbe5788)