fortran MPI_Waitall array_of_requests etc to dimension(*) #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markalle
force-pushed
the
fortran_rank
branch
from
069a36d
to
f798e11
Compare
jsquyres
requested changes
Oct 22, 2021
markalle
force-pushed
the
fortran_rank
branch
from
f798e11
to
dfdf546
Compare
Looking at the 3rd language binding for each MPI function, eg the fortran "USE mpi" or "INCLUDE ’mpif.h’" binding, I looked at the various lines that had "dimension" and "array_of_...". There were several things like MPI_Waitall where I changed - integer, dimension(count), intent(inout) :: array_of_requests + integer, dimension(*), intent(inout) :: array_of_requests and maybe one array_of_statuses for a spawn call Signed-off-by: Mark Allen <markalle@us.ibm.com>
markalle
force-pushed
the
fortran_rank
branch
from
dfdf546
to
121bbe5
Compare
|
@jsquyres ^^^ |
jsquyres
approved these changes
Oct 26, 2021
|
This should be cherry-picked to v5.0.x. I think there should be no effect in cherry-picking this functionality back to v4.0.x and v4.1.x, but given that this functionality has been this way -- literally -- for years and no one has noticed, I think we should take the zero-risk approach and not back-port to v4.0.x and v4.1.x. If the issue comes up, the fix is in 5.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the 3rd language binding for each MPI function, eg
the fortran "USE mpi" or "INCLUDE ’mpif.h’" binding, I looked
at the various lines that had "dimension" and "array_of_...".
There were several things like MPI_Waitall where I changed
and maybe one array_of_statuses for a spawn call
Signed-off-by: Mark Allen markalle@us.ibm.com
#9484