Exterminate all 32 bit platform support from opal atomic (IA32, ARM32, PowerPC32) #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on IA32. With this C11 is now required for ARM32, PowerPC32, and IA32. |
|
@jsquyres This is an easy fix. Though I never said there was one. Turns out there was. |
|
Wouldn't we still want #8575 ? |
|
@rhc54 This would supercede that. With this we will build on IA32 if there is a C11 compiler. It will fail otherwise. |
awlauria
reviewed
Mar 26, 2021
These platforms are losing support with each passing day and it is time to let them go. They will continue to work with a C11 compiler but Open MPI will no longer maintain ASM for these platforms. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
These macros are no longer relevant as all platforms have both 32 and 64-bit atomic math. This is required by Open MPI. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hjelmn
force-pushed
the
exterminate_all_32_bit_atomic_platform_support
branch
from
a6695d5 to
12b02dd
Compare
hjelmn
changed the title
bwbarrett
approved these changes
Mar 29, 2021
|
@hjelmn please cherry-pick to v5.0.x when you get a chance. |
|
brought in a batch of v5.0.x commits here: #8902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: NEWS note for when this is PR'ed to v5.0.x: 32 bit builds are now only supported with C11-capable compilers (e.g., gcc >= 5.4.0).
Note: I don't know that 5.4.0 is the lowest possible gcc with the correct support, but Nathan tested gcc 5.4.0 and it had all the Right C11 Things for 32 bit builds. We did not test lower versions than that. --- Should work all the way back to v4.9.x but the performance will not be as good as recent releases.