Nidmap.c and onesided_aggregation.c Compiler Warnings fix #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
Thanks for the fix. Looks like we can now remove lines 2027 and 2028 in |
awlauria
previously requested changes
Nov 19, 2019
jsquyres
approved these changes
Nov 28, 2019
There was a problem hiding this comment.
@awlauria I think you're right, but given that this is ROMIO (i.e., a 3rd party import into our repo), we usually go for the minimum distance fixes so that the next time we import ROMIO, we can identify the changes that we may need to carry over to the next version.
So I think that just setting it to NULL is fine (and leaving the other 2 lines).
jsquyres
requested changes
Nov 28, 2019
Squash compiler warning. Signed-off-by: William Bailey <wbailey2@nd.edu>
Squash compiler warning. ROMIO is third-party software but has an annoying compiler warning; this is the minimum distance fix. Signed-off-by: William Bailey <wbailey2@nd.edu>
|
I just updated these fixes and split them into two. |
jsquyres
approved these changes
Dec 2, 2019
|
@awlauria Are you ok with this? |
gpaulsen
dismissed
awlauria’s stale review
Dismissing, because Austen is on vacation, and his changes have been applied.
gpaulsen
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some compiler warning messages that appear for uninitialized values for both nidmap.c and onesided_aggregation.c . I found the variables causing these issues.
For nidmap.c there was a declared variable rc which was not initialized so I set it = 0.
For onesided_aggregation.c there was a declared variable *derivedTypePackedSourceBuffer but not initialized. I found the variable declartion and initialized it to = NULL.
Signed-off-by: William Bailey wbailey2@nd.edu