CONTRIBUTING.md: add Github contribution guidelines #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
reviewed
Mar 20, 2018
CONTRIBUTING.md
Outdated
|
|
||
| If you have not already done so, please ensure that: | ||
|
|
||
| 1. Every commit contains exactly this token. You can add this token |
There was a problem hiding this comment.
Change this token to the "Signed-off-by" token
We have a small number of requirements for contributions (e.g., "Signed-off-by"), so let's make sure that people have an easy way of knowing these things. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/contributing-guideliens
branch
from
9949002 to
ed3aa63
Compare
|
@jsquyres Something didn't work right - I'm not seeing the contribution file link when opening an issue or PR. |
|
Bonk - look in |
|
Just to follow up on this PR: it is working. But Github has lame-ified the link. 😦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a small number of requirements for contributions (e.g.,
"Signed-off-by"), so let's make sure that people have an easy way of
knowing these things.
Signed-off-by: Jeff Squyres jsquyres@cisco.com