v2.x: CMA: Fixing logic for CMA system call detection #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OPAL_CMA_NEED_SYSCALL_DEFS is always defined/set to 0 or 1. Therefore instead of checking if the macro is defined, we have to look at the value itself. Signed-off-by: Pavel Shamis (Pasha) <pasharesearch@gmail.com> (cherry picked from commit d984b4b) Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
|
I can confirm that cherry-picking this one commit does resolve the build failure with the 2.1.2rc2 tarball, which I reported in https://www.mail-archive.com/devel@lists.open-mpi.org/msg20340.html |
jsquyres
approved these changes
Aug 22, 2017
|
@hppritcha Good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OPAL_CMA_NEED_SYSCALL_DEFS is always defined/set to 0 or 1. Therefore instead of checking if the macro is defined, we have to look at the value itself.
(cherry picked from commit d984b4b)
Refs: #4122
Though I set milestone to v2.1.2, I don't have strong opinion against deferring it to v2.1.3.