Replace syntax with something less strictly C99 #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHHargrove
reviewed
Jul 5, 2017
| @@ -35,6 +35,7 @@ int mca_btl_ugni_add_procs (struct mca_btl_base_module_t* btl, size_t nprocs, | |||
| mca_btl_ugni_module_t *ugni_module = (mca_btl_ugni_module_t *) btl; | |||
| int rc; | |||
| void *mmap_start_addr; | |||
| struct timeval tv = {0, MCA_BTL_UGNI_CONNECT_USEC}; | |||
There was a problem hiding this comment.
@rhc54 I would advise retaining the named initializer (here and in the other struct timeval case) to yield
struct timeval tv = {.tv_sec = 0, .tv_usec = MCA_BTL_UGNI_CONNECT_USEC};
I say this because POSIX defines the struct with the intentionally vague phrase "shall include at least the following members" used throughout the standard. By my interpretation this does not guarantee their order or even that they are the first two members.
I freely acknowledge that I am being paranoid.
Fixes #3809 Signed-off-by: Ralph Castain <rhc@open-mpi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ralph Castain rhc@open-mpi.org