fcoll/vulcan: fix memory leak #12803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we didn't correctly free the fh->f_aggr_list array in the vulcan file_write_all file. Thanks @andymwood for reporting the issue and @ggouaillardet for identifying the cause for the leak. Fixes Issue open-mpi#12677 (at least partially) Signed-off-by: Edgar Gabriel <edgar.gabriel@amd.com>
janjust
approved these changes
Sep 10, 2024
jsquyres
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we didn't free the fh->f_aggr_list array in the vulcan file_write_all file. Thanks @andymwood for reporting the issue and @ggouaillardet for identifying the cause of the leak. I followed in this pr the pattern that we used for the other variables (i.e. free the array and set the pointer to NULL) to have some uniformity.
Tested on main with the ompi-tests file testsuite, and through a manual backport to 5.0.3 with the hdf5 testsuite (current main does not work for hdf5 because of issue #12742)
Will have to be backported to 4.1.x and 5.0.x branches.
Fixes Issue #12677 (at least partially)