pml/cm,ob1: pack data from application buffer in successive MPI_Start calls #12797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug exposed by MTT MPI_Bsend_init_overtake_c, where - MPI_Bsend_init(buf, ..., req) - MPI_Start(req) - MPI_Wait(req, stat) - modify(buf) - MPI_Start(req) // this does not send the updated data - MPI_Wait(buf) This is because PML/CM uses a bounce buffer send_req.req_buff to pack data from the application buffer in MPI_Bsend_int but not MPI_Start. This patch adds a step to pack data from the application buffer in each MPI_Start call. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
Signed-off-by: George Bosilca <gbosilca@nvidia.com>
wenduwan
changed the title
|
@bosilca ready to go? |
|
I should not review my own code. Someone else need to do it. @hppritcha maybe ? |
|
Howard should be back from vacation next week or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug exposed by MTT MPI_Bsend_init_overtake_c, where
This is because PML/CM uses a bounce buffer send_req.req_buff to pack data from the application buffer in MPI_Bsend_int but not MPI_Start.
This patch adds a step to pack data from the application buffer in each MPI_Start call.