Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: fix IGNORE_TKR check #12745

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggouaillardet
Copy link
Contributor

As reported by Chris Parrott in #12681, the enhanced test was buggy. Pass the expected argument to make it Fortran compliant and LLVM 17 and above happy compilers

As reported by Chris Parrott in open-mpi#12681, the enhanced test was buggy.
Pass the expected argument to make it Fortran compliant and
LLVM 17 and above happy compilers

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggouaillardet Did you make this a draft PR for a reason? Or is it ready to go?

@ggouaillardet
Copy link
Contributor Author

I initially made it a draft waiting for CI, and I kept it a draft because it is not ready to go (e.g. it "breaks" nvfortran).

At this stage, I would keep things as-is (e.g. close this PR without merging) and add a note we will only support flang-new from LLVM 19. I am open to suggestions.

@jsquyres
Copy link
Member

@cparrott73 Got any suggestions?

@cparrott73
Copy link

@jsquyres @ggouaillardet - let me follow up with this with our Fortran experts.

@janjust
Copy link
Contributor

janjust commented Aug 16, 2024

@cparrott73 just checking if you had time to follow up with the Fortran guys?

@cparrott73
Copy link

@cparrott73 just checking if you had time to follow up with the Fortran guys?

Sorry, have been dealing with a few fires this week.

I pinged our Fortran folks on Slack about this, and referenced this PR. Hopefully they will either chime in here or let me know what their thoughts are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants