fortran/use-mpi-f08: add support for Fortran 2018 ISO_Fortran_binding.h try number two #10302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot:ompi:retest |
hppritcha
force-pushed
the
topic/f08_iso_fortran_bindings
branch
from
b2360a3
to
22e2b20
Compare
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> Conflicts: config/ompi_setup_mpi_fortran.m4
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
…tines Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
…broutines Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Fortran 2008 bindings can now be built if the Fortran compiler supports IGNORE_TKR *or* Fortran ISO bindings. Some other fixes were included in this commit. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
interfaces Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
and isendrecv_replace Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
topic/f08_iso_fortran_bindings
branch
from
22e2b20
to
48ab65f
Compare
Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
jtronge
added a commit
to jtronge/ompi
that referenced
this pull request
Feb 7, 2024
This refactors the Python scripts for generating the C and Fortran interfaces into ompi/mpi/bindings/ and extends the Fortran code for more complicated functions. TS 29113 support is also added here, with code imported from PR open-mpi#10302. Signed-off-by: Jake Tronge <jtronge@lanl.gov>
jtronge
added a commit
to jtronge/ompi
that referenced
this pull request
Aug 12, 2024
This updates fortran/use-mpi-f08 to generate most of the Fortran bindings from a script and template files. It also adds support for Fortran TS 29113 when possible, allowing for better Fortran array handling that matches the standard. The C files were imported from PR open-mpi#10302 and converted to templates to be fed into the binding script. Co-authored-by: Gilles Gouaillardet <gilles@rist.or.jp> Co-authored-by: Howard Pritchard <howardp@lanl.gov> Signed-off-by: Jake Tronge <jtronge@lanl.gov>
jtronge
added a commit
to jtronge/ompi
that referenced
this pull request
Aug 12, 2024
This updates fortran/use-mpi-f08 to generate most of the Fortran bindings from a script and template files. It also adds support for Fortran TS 29113 when possible, allowing for better Fortran array handling that matches the standard. The C files were imported from PR open-mpi#10302 and converted to templates to be fed into the binding script. Co-authored-by: Gilles Gouaillardet <gilles@rist.or.jp> Co-authored-by: Howard Pritchard <howardp@lanl.gov> Signed-off-by: Jake Tronge <jtronge@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of @ggouaillardet 's https://github.com/ggouaillardet/ompi/tree/dev/f08_cdesc branch, rebased on top of master and some additional patching.
This PR addresses the fact that Open MPI is out of compliance with the MPI standard wrt F08 interfaces when built with Fortran compilers that fully support Fortran TS 29113. This TS is part of the Fortran 2018 standard. See section 19.1.2 of the MPI 4.0 standard for further details.
Related to #6569
Compilers I've tested that can generate the ISO Fortran bindings are gcc > 8, Intel OneAPI compilers.
Marked as a draft since there are still open items.