-
Notifications
You must be signed in to change notification settings - Fork 878
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
opal/atomic: always use C11 atomics if available
This commit disables the use of both the builtin and hand-written atomics if proper C11 atomic support is detected. This is the first step towards requiring the availability of C11 atomics for the C compiler used to build Open MPI. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
- Loading branch information
Showing
9 changed files
with
295 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,240 @@ | ||
| /* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */ | ||
| /* | ||
| * Copyright (c) 2018 Los Alamos National Security, LLC. All rights | ||
| * reserved. | ||
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow | ||
| * | ||
| * $HEADER$ | ||
| */ | ||
|
|
||
| /* This file provides shims between the opal atomics interface and the C11 atomics interface. It | ||
| * is intended as the first step in moving to using C11 atomics across the entire codebase. Once | ||
| * all officially supported compilers offer C11 atomic (GCC 4.9.0+, icc 2018+, pgi, xlc, etc) then | ||
| * this shim will go away and the codebase will be updated to use C11's atomic support | ||
| * directly. | ||
| * This shim contains some functions already present in atomic_impl.h because we do not include | ||
| * atomic_impl.h when using C11 atomics. It would require alot of #ifdefs to avoid duplicate | ||
| * definitions to be worthwhile. */ | ||
|
|
||
| #if !defined(OPAL_ATOMIC_STDC_H) | ||
| #define OPAL_ATOMIC_STDC_H | ||
|
|
||
| #include <stdatomic.h> | ||
| #include <stdint.h> | ||
| #include "opal/include/opal_stdint.h" | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_MEM_BARRIER 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_COMPARE_EXCHANGE_32 1 | ||
| #define OPAL_HAVE_ATOMIC_SWAP_32 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_MATH_32 1 | ||
| #define OPAL_HAVE_ATOMIC_ADD_32 1 | ||
| #define OPAL_HAVE_ATOMIC_AND_32 1 | ||
| #define OPAL_HAVE_ATOMIC_OR_32 1 | ||
| #define OPAL_HAVE_ATOMIC_XOR_32 1 | ||
| #define OPAL_HAVE_ATOMIC_SUB_32 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_COMPARE_EXCHANGE_64 1 | ||
| #define OPAL_HAVE_ATOMIC_SWAP_64 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_MATH_64 1 | ||
| #define OPAL_HAVE_ATOMIC_ADD_64 1 | ||
| #define OPAL_HAVE_ATOMIC_AND_64 1 | ||
| #define OPAL_HAVE_ATOMIC_OR_64 1 | ||
| #define OPAL_HAVE_ATOMIC_XOR_64 1 | ||
| #define OPAL_HAVE_ATOMIC_SUB_64 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_LLSC_32 0 | ||
| #define OPAL_HAVE_ATOMIC_LLSC_64 0 | ||
| #define OPAL_HAVE_ATOMIC_LLSC_PTR 0 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_MIN_32 1 | ||
| #define OPAL_HAVE_ATOMIC_MAX_32 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_MIN_64 1 | ||
| #define OPAL_HAVE_ATOMIC_MAX_64 1 | ||
|
|
||
| #define OPAL_HAVE_ATOMIC_SPINLOCKS 1 | ||
|
|
||
| static inline void opal_atomic_mb (void) | ||
| { | ||
| atomic_thread_fence (memory_order_seq_cst); | ||
| } | ||
|
|
||
| static inline void opal_atomic_wmb (void) | ||
| { | ||
| atomic_thread_fence (memory_order_release); | ||
| } | ||
|
|
||
| static inline void opal_atomic_rmb (void) | ||
| { | ||
| atomic_thread_fence (memory_order_acquire); | ||
| } | ||
|
|
||
| #define opal_atomic_compare_exchange_strong_32 atomic_compare_exchange_strong | ||
| #define opal_atomic_compare_exchange_strong_64 atomic_compare_exchange_strong | ||
| #define opal_atomic_compare_exchange_strong_ptr atomic_compare_exchange_strong | ||
| #define opal_atomic_compare_exchange_strong_acq_32(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_acquire, memory_order_relaxed) | ||
| #define opal_atomic_compare_exchange_strong_acq_64(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_acquire, memory_order_relaxed) | ||
| #define opal_atomic_compare_exchange_strong_acq_ptr(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_acquire, memory_order_relaxed) | ||
|
|
||
| #define opal_atomic_compare_exchange_strong_rel_32(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_release, memory_order_relaxed) | ||
| #define opal_atomic_compare_exchange_strong_rel_64(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_release, memory_order_relaxed) | ||
| #define opal_atomic_compare_exchange_strong_rel_ptr(addr, compare, value) atomic_compare_exchange_strong_explicit (addr, compare, value, memory_order_release, memory_order_relaxed) | ||
|
|
||
| #define opal_atomic_compare_exchange_strong atomic_compare_exchange_strong | ||
| #define opal_atomic_compare_exchange_strong_acq(addr, oldval, newval) atomic_compare_exchange_strong_explicit (addr, oldval, newval, memory_order_acquire, memory_order_relaxed) | ||
| #define opal_atomic_compare_exchange_strong_rel(addr, oldval, newval) atomic_compare_exchange_strong_explicit (addr, oldval, newval, memory_order_release, memory_order_relaxed) | ||
|
|
||
| #define opal_atomic_swap_32 atomic_exchange | ||
| #define opal_atomic_swap_64 atomic_exchange | ||
| #define opal_atomic_swap_ptr atomic_exchange | ||
|
|
||
| #define OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(op, bits, type, operator) \ | ||
| static inline type opal_atomic_fetch_ ## op ##_## bits (opal_atomic_ ## type *addr, type value) \ | ||
| { \ | ||
| return atomic_fetch_ ## op (addr, value); \ | ||
| } \ | ||
| \ | ||
| static inline type opal_atomic_## op ## _fetch_ ## bits (opal_atomic_ ## type *addr, type value) \ | ||
| { \ | ||
| return atomic_fetch_ ## op (addr, value) operator value; \ | ||
| } | ||
|
|
||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(add, 32, int32_t, +) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(add, 64, int64_t, +) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(add, size_t, size_t, +) | ||
|
|
||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(sub, 32, int32_t, -) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(sub, 64, int64_t, -) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(sub, size_t, size_t, -) | ||
|
|
||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(or, 32, int32_t, |) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(or, 64, int64_t, |) | ||
|
|
||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(xor, 32, int32_t, ^) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(xor, 64, int64_t, ^) | ||
|
|
||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(and, 32, int32_t, &) | ||
| OPAL_ATOMIC_STDC_DEFINE_FETCH_OP(and, 64, int64_t, &) | ||
|
|
||
| #define opal_atomic_add (void) atomic_fetch_add | ||
|
|
||
| static inline int32_t opal_atomic_fetch_min_32 (opal_atomic_int32_t *addr, int32_t value) | ||
| { | ||
| int32_t old = *addr; | ||
| do { | ||
| if (old <= value) { | ||
| break; | ||
| } | ||
| } while (!opal_atomic_compare_exchange_strong_32 (addr, &old, value)); | ||
|
|
||
| return old; | ||
| } | ||
|
|
||
| static inline int32_t opal_atomic_fetch_max_32 (opal_atomic_int32_t *addr, int32_t value) | ||
| { | ||
| int32_t old = *addr; | ||
| do { | ||
| if (old >= value) { | ||
| break; | ||
| } | ||
| } while (!opal_atomic_compare_exchange_strong_32 (addr, &old, value)); | ||
|
|
||
| return old; | ||
| } | ||
|
|
||
| static inline int64_t opal_atomic_fetch_min_64 (opal_atomic_int64_t *addr, int64_t value) | ||
| { | ||
| int64_t old = *addr; | ||
| do { | ||
| if (old <= value) { | ||
| break; | ||
| } | ||
| } while (!opal_atomic_compare_exchange_strong_64 (addr, &old, value)); | ||
|
|
||
| return old; | ||
| } | ||
|
|
||
| static inline int64_t opal_atomic_fetch_max_64 (opal_atomic_int64_t *addr, int64_t value) | ||
| { | ||
| int64_t old = *addr; | ||
| do { | ||
| if (old >= value) { | ||
| break; | ||
| } | ||
| } while (!opal_atomic_compare_exchange_strong_64 (addr, &old, value)); | ||
|
|
||
| return old; | ||
| } | ||
|
|
||
| static inline int32_t opal_atomic_min_fetch_32 (opal_atomic_int32_t *addr, int32_t value) | ||
| { | ||
| int32_t old = opal_atomic_fetch_min_32 (addr, value); | ||
| return old <= value ? old : value; | ||
| } | ||
|
|
||
| static inline int32_t opal_atomic_max_fetch_32 (opal_atomic_int32_t *addr, int32_t value) | ||
| { | ||
| int32_t old = opal_atomic_fetch_max_32 (addr, value); | ||
| return old >= value ? old : value; | ||
| } | ||
|
|
||
| static inline int64_t opal_atomic_min_fetch_64 (opal_atomic_int64_t *addr, int64_t value) | ||
| { | ||
| int64_t old = opal_atomic_fetch_min_64 (addr, value); | ||
| return old <= value ? old : value; | ||
| } | ||
|
|
||
| static inline int64_t opal_atomic_max_fetch_64 (opal_atomic_int64_t *addr, int64_t value) | ||
| { | ||
| int64_t old = opal_atomic_fetch_max_64 (addr, value); | ||
| return old >= value ? old : value; | ||
| } | ||
|
|
||
| #define OPAL_ATOMIC_LOCK_UNLOCKED false | ||
| #define OPAL_ATOMIC_LOCK_LOCKED true | ||
|
|
||
| #define OPAL_ATOMIC_LOCK_INIT ATOMIC_FLAG_INIT | ||
|
|
||
| typedef atomic_flag opal_atomic_lock_t; | ||
|
|
||
| /* | ||
| * Lock initialization function. It set the lock to UNLOCKED. | ||
| */ | ||
| static inline void opal_atomic_lock_init (opal_atomic_lock_t *lock, bool value) | ||
| { | ||
| atomic_flag_clear (lock); | ||
| } | ||
|
|
||
|
|
||
| static inline int opal_atomic_trylock (opal_atomic_lock_t *lock) | ||
| { | ||
| return (int) atomic_flag_test_and_set (lock); | ||
| } | ||
|
|
||
|
|
||
| static inline void opal_atomic_lock(opal_atomic_lock_t *lock) | ||
| { | ||
| while (opal_atomic_trylock (lock)) { | ||
| } | ||
| } | ||
|
|
||
|
|
||
| static inline void opal_atomic_unlock (opal_atomic_lock_t *lock) | ||
| { | ||
| atomic_flag_clear (lock); | ||
| } | ||
|
|
||
| /* NTH: will probably have to make this stronger to avoid using a lock-based cmpxchng 128 */ | ||
| #if HAVE_OPAL_INT128_T | ||
|
|
||
| #define opal_atomic_compare_exchange_strong_128 atomic_compare_exchange_strong | ||
| #define OPAL_HAVE_ATOMIC_COMPARE_EXCHANGE_128 1 | ||
|
|
||
| #endif | ||
|
|
||
| #endif /* !defined(OPAL_ATOMIC_STDC_H) */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.