Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POSIX compatible redirect #16

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

jeroen-mostert
Copy link
Contributor

The syntax 1>&/dev/null 2>&1 is not POSIX compliant; this causes builds to fail on shells which don't support this specific syntax (either natively or in POSIX mode), like dash. The fix is simple enough and actually leads to shorter code; just leave off the 1>& specifier.

Copy link

github-actions bot commented Aug 2, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2f7c65e: Use POSIX compatible redirect

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Signed-off-by: Jeroen Mostert <jeroen.mostert@cm.com>
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thank you!)

@bwbarrett Do you concur?

@bwbarrett bwbarrett merged commit 91ec438 into open-mpi:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants